Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for az login --identity #47

Closed
wants to merge 3 commits into from

Conversation

gaurav137
Copy link
Contributor

Was trying to use this container in a scenario where our service container uses az cli and would do az login --identity when running in Azure and would like the same to work in a local development environment also. Working backwards from https://github.com/Azure/msrestazure-for-python/blob/master/msrestazure/azure_active_directory.py#L474 added support for enabling this scenario.

@gaurav137 gaurav137 requested a review from a team as a code owner June 27, 2024 13:36
@asimmon
Copy link
Member

asimmon commented Jun 27, 2024

Hi @gaurav137, thanks for your contribution! I tried it using the .NET Azure Identity SDK and it works well.

I'd like to merge your PR (with a small fix, replacing string with var), but due to our compliance workflow, which we acknowledge is not ideal for external contributors at the moment, and the inability to use access workflow secrets in forks, I had to open a new PR: #48

I retained your commits, so your name will appear among the contributors:

image

@asimmon asimmon closed this Jun 27, 2024
@asimmon
Copy link
Member

asimmon commented Jun 28, 2024

Your changes has been released in 1.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants