feat: members detail and remove members

[borgoat]

I realised we were missing the member details page altogether and also an issue to tackle it - this is not quite done as the only functionality right now is to delete a member - but at least we can reuse this page as base for other functionality such as #24 and #17

[inpt333]

@borgoat I can remove myself from the group being admin and only member of the group. Is that right?

And after doing that, the group remains as zombie in the DB because I cannot invite anyone or remove the group anymore, although I still see the group in the list.

[borgoat]

I think it is right, yes. Although we should probably have a trigger in Postgres covering the 2 cases, if there's someone else they should automatically become admin, if not it should delete the group

[inpt333]

@borgoat I can remove myself from the group being admin and only member of the group. Is that right?

And after doing that, the group remains as zombie in the DB because I cannot invite anyone or remove the group anymore, although I still see the group in the list.

On top of this, not looking at the code to not be biased as user, I don't understand the non-clickable options that appear on top:

• For me as admin:

• For other non-admin users:

[inpt333]

I've managed to crash the app. Steps:

• Create group and add another member.
• Create some event.
• Both users reply to the event.
• Remove member from group and navigate back. Two things here:
  • There are still two replies.
  • Click on the event and an exception will be thrown.

[borgoat]

Thanks I'll look into the crash - I think it's related to another issue I found by loading the migrated data...

As for the view, it is indeed confusing, but I guess it's 2 separate problems:

• the view for one's own user should probably be quite different and have some explanations as what happens when leaving the group... the dismissal action should not be there
• the invites are not for non-admins, but rather for members that do not yet have a "profile" (i.e. guests that have not yet signed up/joined the group) - maybe I should add a brief explanation in-app? (also it's not functional yet, just a placeholder... I think I need to revisit the create member form to make this properly...)

[cloudflare-workers-and-pages]

Deploying appforit with    Cloudflare Pages

Latest commit:	25f5fb0
Status:	✅  Deploy successful!
Preview URL:	https://272934f9.appforit.pages.dev
Branch Preview URL:	https://feat-members.appforit.pages.dev

View logs

[inpt333]

Thanks I'll look into the crash - I think it's related to another issue I found by loading the migrated data...

As for the view, it is indeed confusing, but I guess it's 2 separate problems:

• the view for one's own user should probably be quite different and have some explanations as what happens when leaving the group... the dismissal action should not be there
• the invites are not for non-admins, but rather for members that do not yet have a "profile" (i.e. guests that have not yet signed up/joined the group) - maybe I should add a brief explanation in-app? (also it's not functional yet, just a placeholder... I think I need to revisit the create member form to make this properly...)

Maybe we should do a first user test with Anastasiia to find out what's not clear. I am personally already biased to have an opinion.

By the way, the issue with removing my own user from a group is still there. Maybe the PR was not ready yet? 🤔

[borgoat]

I've managed to crash the app. Steps:

• Create group and add another member.

• Create some event.

• Both users reply to the event.

• Remove member from group and navigate back. Two things here:

  • There are still two replies.
  • Click on the event and an exception will be thrown.

I also failed to reproduce this... could it be that we have different DB schemas? Did you run a supabase db reset on your local environment?

[inpt333]

I've managed to crash the app. Steps:

• Create group and add another member.

• Create some event.

• Both users reply to the event.

• Remove member from group and navigate back. Two things here:

  • There are still two replies.
  • Click on the event and an exception will be thrown.

I also failed to reproduce this... could it be that we have different DB schemas? Did you run a supabase db reset on your local environment?

It might be. I probably didn't reset before the crash. Let's move on.