Draft: Chore/ci compare versions #101
Conversation
|
I'm not sure this will do what we want it to do: this will create new release and tag when pubspec is updated, but the point of separating the release from the build number is that until the release is done on the store, we keep reusing the version number and the tag is shifted forward; until we decide to publish the app and then we "freeze" the tag by releasing on GitHub too, and then bump the version. If we do it this way we could just as well get rid of releases and tags, because they would just match the point when a commit was made, but not the actual release to the store. |
|
As for the build failure, that is actually intended, and it happened because "I'm Very Stupid"™️ - I forgot to bump the pubspec version in my PR 😅 which is a good point.. we're not used to do it and I completely forgot... probably a better solution would be to have a check in the verify job, instead of waiting for things to be merged to notice. But as I said this won't really solve it; the failure will just happen in Xcode instead. |
@borgoat just think about it (4aeda09#r150054222) and just close this PR if you don't agree. I won't be offended 😉
Just keep in mind https://github.com/appforit/appforit/actions/runs/12216881020/job/34080460035