Skip to content

Commit

Permalink
ci: attempt at sentry without +1
Browse files Browse the repository at this point in the history
  • Loading branch information
borgoat committed Jan 3, 2025
1 parent cfc48d3 commit cc359a2
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,6 @@ jobs:
SENTRY_AUTH_TOKEN: ${{ secrets.SENTRY_AUTH_TOKEN }}
# The +1 is explicitly provided for consistency with the Xcode Cloud build: since we set SENTRY_DIST below,
# Sentry will automatically pick that as build number anyway.
SENTRY_RELEASE: "is.giorgio.app.parousia@${{ steps.parse_pubspec.outputs.pubspec_version }}+1"
SENTRY_RELEASE: "is.giorgio.app.parousia@${{ steps.parse_pubspec.outputs.pubspec_version }}"
SENTRY_DIST: ${{ github.run_number }}
run: dart run sentry_dart_plugin
6 changes: 3 additions & 3 deletions ios/ci_scripts/ci_post_xcodebuild.sh
Original file line number Diff line number Diff line change
Expand Up @@ -10,10 +10,10 @@ cd "$CI_PRIMARY_REPOSITORY_PATH" # change working directory to the root of your
export PATH="$PATH:$HOME/flutter/bin"

# We need a common release name for Sentry.
# This command gets the version from the pubspec.yaml file - including the +1 build number.
# Since we set SENTRY_DIST below, Sentry will actually use that as the build number.
# This command gets the version from the pubspec.yaml file - without the +1 part.
# SENTRY_DIST below will be the CI_BUILD_NUMBER.
# This grep command is different from the one in GitHub Actions because here we are on macOS.
SENTRY_RELEASE="is.giorgio.app.parousia@$(grep '^version:' pubspec.yaml | awk '{print $2}')"
SENTRY_RELEASE="is.giorgio.app.parousia@$(grep '^version:' pubspec.yaml | awk -F'[ +]' '{print $2}')"
export SENTRY_RELEASE

# https://docs.sentry.io/platforms/flutter/configuration/options/#dist
Expand Down

0 comments on commit cc359a2

Please sign in to comment.