Skip to content

Commit

Permalink
ci: sentry full release name
Browse files Browse the repository at this point in the history
  • Loading branch information
borgoat committed Jan 4, 2025
1 parent 524de6a commit 024ea15
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 4 deletions.
8 changes: 5 additions & 3 deletions .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,10 @@ jobs:
git fetch origin gh-pages:gh-pages
- name: Compile web and put in gh-pages branch
env:
# This should ensure that the web build has the same settings as mobile apps to configure Sentry consistently
SENTRY_RELEASE: "is.giorgio.app.parousia@${{ steps.parse_pubspec.outputs.pubspec_version }}+${{ github.run_number }}"
SENTRY_DIST: ${{ github.run_number }}
run: dart run peanut

- name: Push gh-pages
Expand Down Expand Up @@ -115,8 +119,6 @@ jobs:
- name: Upload to Sentry
env:
SENTRY_AUTH_TOKEN: ${{ secrets.SENTRY_AUTH_TOKEN }}
# The +1 is explicitly provided for consistency with the Xcode Cloud build: since we set SENTRY_DIST below,
# Sentry will automatically pick that as build number anyway.
SENTRY_RELEASE: "is.giorgio.app.parousia@${{ steps.parse_pubspec.outputs.pubspec_version }}"
SENTRY_RELEASE: "is.giorgio.app.parousia@${{ steps.parse_pubspec.outputs.pubspec_version }}+${{ github.run_number }}"
SENTRY_DIST: ${{ github.run_number }}
run: dart run sentry_dart_plugin
2 changes: 1 addition & 1 deletion ios/ci_scripts/ci_post_xcodebuild.sh
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export PATH="$PATH:$HOME/flutter/bin"
# This command gets the version from the pubspec.yaml file - without the +1 part.
# SENTRY_DIST below will be the CI_BUILD_NUMBER.
# This grep command is different from the one in GitHub Actions because here we are on macOS.
SENTRY_RELEASE="is.giorgio.app.parousia@$(grep '^version:' pubspec.yaml | awk -F'[ +]' '{print $2}')"
SENTRY_RELEASE="is.giorgio.app.parousia@$(grep '^version:' pubspec.yaml | awk -F'[ +]' '{print $2 "+" $3}')"
export SENTRY_RELEASE

# https://docs.sentry.io/platforms/flutter/configuration/options/#dist
Expand Down

0 comments on commit 024ea15

Please sign in to comment.