Fix clippy warnings

Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "rana"
-version = "0.4.1"
+version = "0.5.0"
 edition = "2021"
 license = "MIT"
 authors = ["Francisco Calderón <[email protected]>"]

src/cli.rs

@@ -62,25 +62,21 @@ targets as a comma-separated list."
     )]
     pub num_cores: usize,
 
-
     #[arg(
         short = 'r',
         long = "restore",
         help = "Restore from mnemonic to public private key",
         default_value_t = String::from(""),
         required = false
-        
     )]
     pub mnemonic: String,
 
-
     #[arg(
         short = 'g',
         long = "generate",
         help = "Generate mnemonic using wordcount. Should be 12,18 or 24",
         default_value_t = 0,
         required = false
-        
     )]
     pub word_count: usize,
 
@@ -90,10 +86,9 @@ targets as a comma-separated list."
         help = "Passphrase used for restoring mnemonic to keypair",
         default_value_t = String::from(""),
         required = false
-        
     )]
     pub mnemonic_passphrase: String,
-    
+
     #[arg(
         short,
         long = "qr",

src/lib.rs

@@ -1,4 +1,4 @@
 pub mod cli;
-pub mod tests;
 pub mod mnemonic;
-pub mod utils;
+pub mod tests;
+pub mod utils;

src/main.rs

@@ -25,7 +25,7 @@ fn main() -> Result<(), Box<dyn Error>> {
     let parsed_args = CLIArgs::parse();
 
     // Handle mnemonic part if arguments is set
-    if parsed_args.mnemonic.len() > 0 {
+    if !parsed_args.mnemonic.is_empty() {
         handle_mnemonic(&parsed_args);
     }
 
@@ -155,7 +155,7 @@ fn main() -> Result<(), Box<dyn Error>> {
                     uses_mnemonic = Some(mnemonic.clone());
                     keys = Keys::from_mnemonic(
                         mnemonic.to_string(),
-                        Some(format!("{}", passphrase.as_str())),
+                        Some(passphrase.as_str().to_string()),
                     )
                     .expect("Error generating keys from mnemonic");
                     hexa_key = keys.public_key().to_hex();
@@ -254,11 +254,8 @@ fn main() -> Result<(), Box<dyn Error>> {
                 }
 
                 let mut mnemonic_str = None;
-                match uses_mnemonic {
-                    Some(mnemonic_obj) => {
-                        mnemonic_str = Some(mnemonic_obj.to_string());
-                    }
-                    None => {}
+                if let Some(mnemonic_obj) = uses_mnemonic {
+                    mnemonic_str = Some(mnemonic_obj.to_string());
                 }
 
                 // if one of the required conditions is satisfied

src/mnemonic.rs

@@ -8,7 +8,7 @@ use nostr_sdk::prelude::{FromMnemonic, GenerateMnemonic, Keys, ToBech32};
 pub fn handle_mnemonic(parsed_args: &CLIArgs) {
     if parsed_args.word_count > 0 {
         let mut word_count = parsed_args.word_count;
-        if parsed_args.word_count <= 0 || parsed_args.word_count > 24 {
+        if parsed_args.word_count == 0 || parsed_args.word_count > 24 {
             word_count = 12;
         }
         let mnemonic = Keys::generate_mnemonic(word_count).expect("Couldn't not generate mnemonic");
@@ -31,7 +31,7 @@ pub fn handle_mnemonic(parsed_args: &CLIArgs) {
         exit(0)
     }
 
-    if parsed_args.mnemonic.len() > 0 {
+    if !parsed_args.mnemonic.is_empty() {
         let keys = Keys::from_mnemonic(
             parsed_args.mnemonic.to_string(),
             Some(parsed_args.mnemonic_passphrase.to_string()),

src/utils.rs

@@ -47,8 +47,7 @@ pub fn print_keys(
 
     println!("Found matching public key: {xonly_public_key}");
 
-    let private_hex = secret_key.clone();
-    println!("Nostr private key: {private_hex:>72}");
+    println!("Nostr private key: {secret_key:>72}");
 
     println!(
         "Nostr public key (npub): {:>65}",
@@ -62,15 +61,12 @@ pub fn print_keys(
         "Nostr private key (nsec): {:>64}",
         bech32::encode(
             "nsec",
-            hex::decode(private_hex)?.to_base32(),
+            hex::decode(secret_key)?.to_base32(),
             Variant::Bech32
         )?
     );
-    match mnemonic {
-        Some(mnemonic_value) => {
-            println!("Mnemonic: {}", mnemonic_value);
-        }
-        None => {}
+    if let Some(mnemonic_value) = mnemonic {
+        println!("Mnemonic:                  {}", mnemonic_value);
     }
 
     Ok(())