Don't flag errors in class "Success" #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
E.g. if the operation was cancelled, that's not an error. Signed-off-by: Bryan Boreham <[email protected]>
|
LGTM Though, I'm not sure what that client argument is suppose to be for. Could it be simplified to if c != Success {
ext.Error.Set(span, true)
} |
|
I suppose it's there so that the server doesn't mark its span as an error if the problem originated from the client. |
|
@bboreham - Looks like there's a test case that also needs to be updated for this https://circleci.com/gh/opentracing-contrib/go-grpc/2?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link. Could you put in a follow up PR for it? |
I too was puzzled.
That can't be it - |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
E.g. if the operation was cancelled, that's not an error.
Fixes grpc-ecosystem/grpc-opentracing#44