Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update grpc-opentracing to latest version at new home #1113

Merged
merged 3 commits into from
Nov 19, 2018

Conversation

bboreham
Copy link
Contributor

@bboreham bboreham commented Nov 9, 2018

This is primarily to stop marking cancelled operations as errors - opentracing-contrib/go-grpc#1

Also update weaveworks/common to make all use of grpc-ecosystem libraries consistent, and bring in one bug fix "Fix dropped namespace in url parsing (weaveworks/common#128)".

Signed-off-by: Bryan Boreham <[email protected]>
This makes all use of grpc-ecosystem libraries consistent, and brings
in one bug fix "Fix dropped namespace in url parsing (weaveworks/common#128)".

Signed-off-by: Bryan Boreham <[email protected]>
@tomwilkie
Copy link
Contributor

Are we sure https://github.com/opentracing-contrib/go-grpc is the new home for https://github.com/grpc-ecosystem/grpc-opentracing/tree/master/go/otgrpc? Is there any 'official' decision here?

@bboreham
Copy link
Contributor Author

Issues went ignored in the latter; I found mention of the move somewhere and my PR was merged in the former.

@tomwilkie
Copy link
Contributor

I've sent an email to both communities so see what the latest on this is.

@thisisnotapril
Copy link

From the gRPC perspective; we're happy to point folks wherever. I'd like to confirm the correct repo with the project maintainers though, and I'm not clear on who that is?

@Falco20019
Copy link

Falco20019 commented Nov 19, 2018

There already is an unmerged PR at grpc-ecosystem/grpc-opentracing#43
All our OpenTracing contribution projects can be found at https://github.com/opentracing-contrib following the structure <language>-<framework>. So please use https://github.com/opentracing-contrib/go-grpc as official repository. This was officially decided here: opentracing-contrib/meta#39

@tomwilkie
Copy link
Contributor

Thanks @Falco20019, that LGTM.

@tomwilkie tomwilkie merged commit 2cbb13f into master Nov 19, 2018
@tomwilkie tomwilkie deleted the update-grpc-opentracing branch November 19, 2018 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants