Fix/moved to xunit #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pascal89
approved these changes
Nov 6, 2023
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="FluentAssertions" Version="6.5.1" /> | ||
| <PackageReference Include="Microsoft.AspNetCore.Mvc.Testing" Version="5.0.10" /> |
There was a problem hiding this comment.
While you're touching it. You might as well be updating the package references, because this package for example is already at version 7.x.x
| @@ -2,7 +2,7 @@ | |||
| using System.IO; | |||
| using System.Reflection; | |||
|
|
|||
| namespace Growthbook.Tests.Json; | |||
| namespace GrowthBook.Tests.Json; | |||
There was a problem hiding this comment.
Looks like I wasn't the only one misspelling GrowthBook
paul-franke
approved these changes
Nov 6, 2023
Of course! |
|
@darklordzw Would you be able to publish a new version of the package any time soon? Thanks in advance 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #18 , fixes #17