Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

An 'All' region + Line charts #2

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

An 'All' region + Line charts #2

wants to merge 5 commits into from

Conversation

zyx
Copy link

@zyx zyx commented Jul 4, 2014

Also fixed an exception I was getting when running this with empty tables.
Let me know if you'd rather have this split out into individual branches for each feature.

@grosskur
Copy link
Owner

grosskur commented Jul 7, 2014

Wow, this is awesome. Nice work! A couple of thoughts:

  • The lines don't always run to the edges of the chart. Rather, they run between the first and last data points in the viewing area. I'm not exactly sure how to fix this. It seems like the chart would need to know about the closest data points off the left and right sides of the window and extend horizontal lines appropriately. It might not be fixable without modifying nvd3 somehow.
  • When two lines are following the exact same path, one line "wins" and covers up the other line. I think the graphs in the AWS console draw the lines one pixel apart to avoid this. Neither way is perfect, and again this might not be fixable without modifying nvd3.

Here's an example that demonstrates both: http://localhost:8080/?product=Linux/UNIX%20(Amazon%20VPC)&type=c3.large&region=us-east-1&window=15

Anyway, let me do some more testing... I also want to try with updated d3+nvd3 libraries since the vendored versions are a little old.

@zyx
Copy link
Author

zyx commented Jul 8, 2014

Ahh yes, I remember seeing the first problem. One fix might be to just add an extra point at the current time, equal in price to the most recent point, giving you a line all the way up to the right edge. A similar process could be followed on the left side too.

As for the second problem, I can live with it since it's easy to enable/disable individual lines by clicking on their names in the legend, but it would be nice to have some way to distinguish them otherwise.

@grosskur grosskur force-pushed the master branch 4 times, most recently from d190c4c to 583c665 Compare July 31, 2015 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants