This repository has been archived by the owner on Jul 2, 2020. It is now read-only.
Add cloud_platform scope for Stackdriver Error Reporting #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akm
requested review from
nagachika,
taigou,
minimum2scp,
guemon,
y-hattori and
ko1nksm
nagachika
approved these changes
Aug 23, 2017
minimum2scp
reviewed
Aug 23, 2017
| @@ -70,7 +70,8 @@ | |||
| "https://www.googleapis.com/auth/devstorage.full_control", | |||
| "https://www.googleapis.com/auth/pubsub", | |||
| "https://www.googleapis.com/auth/logging.write", | |||
| "https://www.googleapis.com/auth/monitoring.write" | |||
| "https://www.googleapis.com/auth/monitoring.write", | |||
| "https://www.googleapis.com/auth/cloud-platform" | |||
There was a problem hiding this comment.
@minimum2scp Thanks, I fixed it.
akm
force-pushed
the
features/add_cloud_platform_scope
branch
from
66fd4a1 to
1a0259a
Compare
taigou
approved these changes
Aug 23, 2017
ko1nksm
approved these changes
Aug 23, 2017
y-hattori
approved these changes
Aug 24, 2017
guemon
approved these changes
Aug 25, 2017
minimum2scp
approved these changes
Aug 25, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a scope "https://www.googleapis.com/auth/cloud-platform" for Stackdriver Error Eeporting .
This PR depends on #54 , so see 4ae7437...features/add_cloud_platform_scope for actual differences.
I'm going to add a feature to customize the scopes on #53 because some user application might depend on the scopes for VMs.