Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added aria-label to character counter examples #4484

Merged
merged 1 commit into from
Nov 27, 2024
Merged

Conversation

jcfilben
Copy link
Collaborator

@jcfilben jcfilben commented Nov 26, 2024

Deploy Preview

What does this PR do?

Adds aria-label to the character counter example so screenreader users are aware of the character limit before they start typing

Where should the reviewer start?

What testing has been done on this PR?

In addition to the feature you are implementing, have you checked the following:

General UX Checks

  • Small, medium, and large screen sizes
  • Cross-browsers (FireFox, Chrome, and Safari)
  • Light & dark modes
  • All hyperlinks route properly

Accessibility Checks

  • Keyboard interactions
  • Screen reader experience
  • Run WAVE accessibility plugin (Chrome)

Code Quality Checks

  • Console is free of warnings and errors
  • Passes E2E commit checks
  • Visual snapshots are reasonable

How should this be manually tested?

Any background context you want to provide?

What are the relevant issues?

#3787

Screenshots (if appropriate)

Should this PR be mentioned in Design System updates?

no

Is this change backwards compatible or is it a breaking change?

backwards compatible

Copy link

changeset-bot bot commented Nov 26, 2024

⚠️ No Changeset found

Latest commit: aa15fa2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Nov 26, 2024

Deploy Preview for unrivaled-bublanina-3a9bae ready!

Name Link
🔨 Latest commit aa15fa2
🔍 Latest deploy log https://app.netlify.com/sites/unrivaled-bublanina-3a9bae/deploys/67465d31fb40bd000846dede
😎 Deploy Preview https://deploy-preview-4484--unrivaled-bublanina-3a9bae.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@jcfilben jcfilben merged commit 93089e6 into master Nov 27, 2024
11 of 12 checks passed
@jcfilben jcfilben deleted the a11y-formfield-limit branch November 27, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants