Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add announce to textarea for character limit #4452

Closed
wants to merge 1 commit into from

Conversation

britt6612
Copy link
Collaborator

Deploy Preview

What does this PR do?

This PR adds max and threshold directly on the formfield in our example

Where should the reviewer start?

CharacterCounterExample.js

What testing has been done on this PR?

locally
In addition to the feature you are implementing, have you checked the following:

General UX Checks

  • Small, medium, and large screen sizes
  • Cross-browsers (FireFox, Chrome, and Safari)
  • Light & dark modes
  • All hyperlinks route properly

Accessibility Checks

  • Keyboard interactions
  • Screen reader experience
  • Run WAVE accessibility plugin (Chrome)

Code Quality Checks

  • Console is free of warnings and errors
  • Passes E2E commit checks
  • Visual snapshots are reasonable

How should this be manually tested?

locally with voice over

Any background context you want to provide?

our examples were not following the guidance in which we provide

What are the relevant issues?

closes #3787

Screenshots (if appropriate)

Should this PR be mentioned in Design System updates?

no

Is this change backwards compatible or is it a breaking change?

backwards compatible

Copy link

changeset-bot bot commented Nov 22, 2024

⚠️ No Changeset found

Latest commit: ec3cf0f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Nov 22, 2024

Deploy Preview for unrivaled-bublanina-3a9bae ready!

Name Link
🔨 Latest commit ec3cf0f
🔍 Latest deploy log https://app.netlify.com/sites/unrivaled-bublanina-3a9bae/deploys/6740048be3d026000834d837
😎 Deploy Preview https://deploy-preview-4452--unrivaled-bublanina-3a9bae.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Collaborator

@jcfilben jcfilben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The announcement keeps getting cut off before it reads out. Also I think since the validate max and threshold behavior is built into Grommet it would be nice to also have the announcements for it built into grommet so that people don't need to manually add them

@britt6612
Copy link
Collaborator Author

going to move this code to grommet to be built in.

@britt6612 britt6612 closed this Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Forms with Character Limits - Implementation doesn't follow accessibility guidance
2 participants