Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix paddingY scripts and other minor cleanups #4442

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Conversation

taysea
Copy link
Collaborator

@taysea taysea commented Nov 21, 2024

Deploy Preview

What does this PR do?

This PR makes a few cleanups post restructuring of button[size][kind] --> button[kind][size]:

  1. Fixes verify-paddingY and update-paddingY scripts.
  2. Updates tailwind-app index.css
  3. Incorporates update to xsmall icon size that was released in v0.2.0 but somehow lost on master. The 0.2.0 value equates to 14px which is desired value.

Where should the reviewer start?

What testing has been done on this PR?

In addition to the feature you are implementing, have you checked the following:

General UX Checks

  • Small, medium, and large screen sizes
  • Cross-browsers (FireFox, Chrome, and Safari)
  • Light & dark modes
  • All hyperlinks route properly

Accessibility Checks

  • Keyboard interactions
  • Screen reader experience
  • Run WAVE accessibility plugin (Chrome)

Code Quality Checks

  • Console is free of warnings and errors
  • Passes E2E commit checks
  • Visual snapshots are reasonable

How should this be manually tested?

Any background context you want to provide?

What are the relevant issues?

Screenshots (if appropriate)

Should this PR be mentioned in Design System updates?

Is this change backwards compatible or is it a breaking change?

Copy link

netlify bot commented Nov 21, 2024

Deploy Preview for unrivaled-bublanina-3a9bae ready!

Name Link
🔨 Latest commit e0d0215
🔍 Latest deploy log https://app.netlify.com/sites/unrivaled-bublanina-3a9bae/deploys/673f82dec77dfe000866e9a8
😎 Deploy Preview https://deploy-preview-4442--unrivaled-bublanina-3a9bae.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@taysea taysea merged commit 16205de into master Nov 21, 2024
9 checks passed
@taysea taysea deleted the fix/iconOnly-paddingY branch November 21, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants