Add guidance for CTA buttons vs primary action buttons #2936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
taysea
changed the title
halocline
approved these changes
Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deploy Preview
What does this PR do?
This work is leveraging CTA button theming that is currently only NEXT branch. Once NEXT merges into master, we can update this PR to point back to
stable.Adds guidance regarding primary cta buttons vs primary action buttons -- what they, what their purpose is, when to use. Pulled the content directly from the Brand Synthesis work.
Adds an example of CTA buttons to the Variants section.
Separate question about the overall page structure, I'm wondering if we can do away with the "Guidance" h2 and promote everything from About Button --> Accessibility directly to an h2? Feels like unnecessary nesting.
Where should the reviewer start?
aries-site/src/pages/components/button.mdx
What testing has been done on this PR?
Deployed locally.
In addition to the feature you are implementing, have you checked the following:
General UX Checks
Accessibility Checks
Code Quality Checks
How should this be manually tested?
Any background context you want to provide?
What are the relevant issues?
Related to grommet/grommet-theme-hpe#275
Screenshots (if appropriate)
Should this PR be mentioned in Design System updates?
Yes.
Is this change backwards compatible or is it a breaking change?
Yes.