clarify interpretation of less and greater as before/after #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for grist-help-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
dsagal
reviewed
Dec 25, 2024
| - __`ge`__: (greater than or equal to) find nearest record with sort values >= the given values | ||
| - __`eq`__: (equal to) find nearest record with sort values == the given values | ||
| - __`lt`__: (less than) find nearest (last) record with sort values < (before) the given values | ||
| - __`le`__: (less than or equal to) find nearest record with sort values <= (last before or first equal) the given values |
There was a problem hiding this comment.
I think it should actually be "last that's before or equal" -- if you have multiple equal values to the one you are looking up, it should return the last of these.
| - __`lt`__: (less than) find nearest (last) record with sort values < (before) the given values | ||
| - __`le`__: (less than or equal to) find nearest record with sort values <= (last before or first equal) the given values | ||
| - __`gt`__: (greater than) find nearest (first) record with sort values > (after) the given values | ||
| - __`ge`__: (greater than or equal to) find nearest (first) record with sort values >= (equal or after) the given values |
There was a problem hiding this comment.
this one should be "first equal or after", though I think this is clear as is. Maybe le can be phrased the same way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I welcome edits / rephrasing. This is just the simplest change to make it clear to me, but it might only muddle it for others.
There might also be other places this clarification should be made - IDK.