Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cancel when escape #986

Merged
merged 1 commit into from
May 16, 2024
Merged

fix: cancel when escape #986

merged 1 commit into from
May 16, 2024

Conversation

hexaltation
Copy link
Collaborator

Resolve #340

We choose to bind Escape key behavior to Cancel Button one.

@berhalak berhalak self-requested a review May 16, 2024 14:59
berhalak
berhalak approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@berhalak berhalak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hexaltation

@berhalak berhalak merged commit bb249ff into gristlabs:main May 16, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berhalak berhalak berhalak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Useless filter activation
2 participants
@hexaltation @berhalak