Displays the current authentication mechanism in the admin panel #981
Conversation
Spoffy
commented
May 14, 2024
•
Spoffy
commented
Adds field to the "Security settings" admin display, showing the currently configured authentication mechanism.
Spoffy
force-pushed
the
spoffy/admin-panel-auth-mechanism
branch
from
d851b5c to
9b18b46
Compare
|
Deployed as https://grist-spoffy-admin-panel-auth-mechanism.fly.dev (until 2024-06-13T19:34:16.749Z) |
|
lgtm, but I had to do a double-take because my similar PR for another admin check has no frontend code. That's because it's based on @paulfitz's PR that automated a lot of the frontend boilerplate. This PR could be merged now, but from my understanding some of it would have to be redone (either removed or marked as redundant) when @paulfitz's PR is merged. |
You are right @jordigh that with some upcoming code the probe results could have been rendered automatically. But the auth section is slated to grow in a pretty specialized way, so this is a good start to have and I don't expect it to evaporate. We also want to emphasize some key pieces of security and make them "pop" visually in the panel. The sandboxing section is also something that could now be rendered automatically but retains its own section to emphasize it. |
