Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OIDC: ensure that email_veridied is set by default #765

Merged

Conversation

fflorent
Copy link
Collaborator

This PR proposes to make sure that the email_verified property is set to true in user claims.

By default, the property is checked, so we can be sure the registered user would have access to their email account before accessing to Grist.

@fflorent fflorent force-pushed the openid-use-email-verified branch from 09ecc22 to 9b0f2c3 Compare November 22, 2023 16:33
@fflorent fflorent requested a review from dsagal November 22, 2023 16:33
Copy link
Member

@dsagal dsagal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. One more tiny tweak please!

app/server/lib/OIDCConfig.ts Outdated Show resolved Hide resolved
@fflorent fflorent force-pushed the openid-use-email-verified branch from 9b0f2c3 to 200edf4 Compare November 22, 2023 19:43
Copy link
Member

@dsagal dsagal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@paulfitz paulfitz merged commit 1fec674 into gristlabs:main Nov 22, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants