Add option to serve Prometheus metrics #671 #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fflorent
commented
Oct 12, 2023
sandbox/run.sh
Outdated
| NODE_PATH=_build:_build/stubs:_build/ext node _build/stubs/app/server/server.js | ||
| if [[ -n "$GRIST_PROMCLIENT_PORT" ]]; then | ||
| require_promclient="--require ./_build/stubs/app/server/prometheus-exporter.js" | ||
| fi |
There was a problem hiding this comment.
If the prom-client dependency is embedded no matter what, do you think we keep that --require option as is or may we just import prometheus-exporter.ts as a regular TS module in stubs/app/server/server.ts and conditionally run server.listen or not there?
There was a problem hiding this comment.
Yes, let's keep it simple, include the dependency unconditionally, and use a regular TS module. Thanks @fflorent
There was a problem hiding this comment.
Alright! That's done here: a7a14e3
paulfitz
reviewed
Oct 23, 2023
sandbox/run.sh
Outdated
| NODE_PATH=_build:_build/stubs:_build/ext node _build/stubs/app/server/server.js | ||
| if [[ -n "$GRIST_PROMCLIENT_PORT" ]]; then | ||
| require_promclient="--require ./_build/stubs/app/server/prometheus-exporter.js" | ||
| fi |
There was a problem hiding this comment.
Yes, let's keep it simple, include the dependency unconditionally, and use a regular TS module. Thanks @fflorent
sandbox/watch.sh
Outdated
| require_promclient="--require ./_build/stubs/app/server/prometheus-exporter.js" | ||
| fi | ||
|
|
||
| ls _build/stubs/app/server |
There was a problem hiding this comment.
Oh yes, sorry, I remove that!
fflorent
force-pushed
the
issue-671-prom-client
branch
from
a7a14e3 to
b30b154
Compare
fflorent
force-pushed
the
issue-671-prom-client
branch
from
b30b154 to
f46ce54
Compare
paulfitz
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
At the ANCT, we faced a Ouf Of Memory crash of Grist. The problem was somehow solved but we'd like to monitor Grist a bit more, beyond logs.
That's the reason of this PR: proposing a Prometheus exporter.
Technical aspects
--requireoption to load the prometheus-exporter.ts moduleResolves #671