-
-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds transfers between stores to external attachments #1358
Draft
Spoffy
wants to merge
29
commits into
main
Choose a base branch
from
spoffy/external-attachments-transfers
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+660
−80
Draft
Changes from all commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
8342a4c
Adds "delete" operator to attachment stores
Spoffy a0cc24c
Enables updating of file info
Spoffy b62bab8
Incremental refactoring towards transfers
Spoffy 76db9e5
Adds functioning transfers of individual files
Spoffy 8b23319
Adds test for attachment file corruption on transfer
Spoffy 71f1314
Adds additional check to file transfer
Spoffy a9d36d3
Adds attachment transfer queue and job
Spoffy 382847d
Adds test for all files being transferred
Spoffy 011e5d1
Adds test for recent transfers taking priority
Spoffy c53c016
Adds test for recent transfer requests taking precedence
Spoffy 7e34d8f
Updates an existing all files transfer if possible
Spoffy 2addc2f
Adds location summary function and misc behaviour tweaks
Spoffy 6de387c
Cleans up transfer logic and adds doc endpoint ID.
Spoffy 7c0ee63
Fixes test compilation problem
Spoffy a44944a
Removes TODO from _performPendingTransfers
Spoffy d10ba26
Makes transfer code more understandable
Spoffy cbaf592
Fixes an inconsistent import
Spoffy 1ffeb45
Fixes a linter issue
Spoffy ca0ee2d
Improves several checks
Spoffy d721c79
Splits findOrAttach file into 2 functions
Spoffy 7153b44
Fixes issue with transfer job not type safety
Spoffy e1c9a8d
Renames "findOrAttachFile" to "attachFileIfNew"
Spoffy 586d5a4
Switches "UNIQUE" constraint check to a "SELECT"
Spoffy 220e6f9
Splits getFileInfo into two functions
Spoffy 83d984e
Splits AttachmentFileManager._addFile into two functions
Spoffy fdc3fa4
Rephrases a comment
Spoffy 2dc01d0
Fixes a failing AttachmentFileManager test
Spoffy 34ac344
Revert "Switches "UNIQUE" constraint check to a "SELECT""
Spoffy 337c128
Adds a comment explaining why UNIQUE constraint is caught.
Spoffy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is an unusually long name for this codebase, but very clear, so 👍