Extract Groups management from HomeDBManager #1342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulfitz
reviewed
Dec 13, 2024
| import { Organization } from "app/gen-server/entity/Organization"; | ||
| import { Workspace } from "app/gen-server/entity/Workspace"; | ||
| import { Document } from "app/gen-server/entity/Document"; | ||
| import { AclRule } from "app/gen-server/entity/AclRule"; |
There was a problem hiding this comment.
Ideally imports are ordered alphabetically, and use of quotes are consistent. Sorry we don't have automatic linting for this.
There was a problem hiding this comment.
@paulfitz I am never really sure about how to sort the imports. How should we sort this line:
import { GroupDescriptor, NonGuestGroup, Resource } from "app/gen-server/lib/homedb/Interfaces";
Should we consider the imported object (GroupDescriptor) or the path ("app/gen-server/lib/homedb/Interfaces") for sorting?
paulfitz
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
I pave the way to implement Groups for SCIM.
Proposed solution
Refactoring for moving the Groups Management outside of HomeDBManager.
Related issues
#870
Has this been tested?
lib/homedb)