Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: delete Docker image artifact during fly deploy #1333

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

jordigh
Copy link
Contributor

@jordigh jordigh commented Dec 3, 2024

This is the relevant API endpoint:

https://octokit.github.io/rest.js/v21/#actions-delete-artifact

Turns out that these artifacts can accumulate and add up to a limit. We don't need the docker image after it's been downloaded and ready to deploy, so just delete it when we're done.

Has this been tested?

  • 👍 yes, I added tests to the test suite
  • 💭 no, because this PR is a draft and still needs work
  • 🙅 no, because this is not relevant here
  • 🙋 no, because I need help

This is the relevant API endpoint:

https://octokit.github.io/rest.js/v21/#actions-delete-artifact

Turns out that these artifacts can accumulate and add up to a limit.
We don't need the docker image after it's been downloaded and ready to
deploy, so just delete it when we're done.
@jordigh jordigh force-pushed the jordigh/delete-fly-artifacts branch from 5c85f00 to 448020b Compare December 3, 2024 22:57
@jordigh jordigh added the preview Launch preview deployment of this PR label Dec 3, 2024
Copy link
Contributor

github-actions bot commented Dec 3, 2024

Deployed commit 448020b765498d1226608ce5a0066474feafdd79 as https://grist-gristlabs-grist-core-jordigh-delete-fly-artifacts.fly.dev (until 2025-01-02T23:10:42.133Z)

@georgegevoian georgegevoian self-requested a review December 4, 2024 16:24
@georgegevoian georgegevoian merged commit 00739d8 into main Dec 4, 2024
11 of 12 checks passed
@georgegevoian georgegevoian deleted the jordigh/delete-fly-artifacts branch December 4, 2024 16:32
@jordigh jordigh removed the preview Launch preview deployment of this PR label Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants