Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow picking the same widget in custom widget gallery #1327

Merged
merged 3 commits into from
Dec 3, 2024

Conversation

georgegevoian
Copy link
Contributor

Context

When changing a widget to a custom widget, the gallery is automatically shown, prompting you to select a custom widget. This happens even when the widget type is unchanged (e.g. changing just the select by or group by columns). But since
the primary button in the gallery is disabled if the selected widget is the same as the current widget, you can't confirm
that you'd like to use the same widget; all you can do is dismiss the gallery by closing it, which isn't always obvious.

Proposed solution

You should be able to select any widget from the gallery, even if it's the same widget that's currently in use.

Has this been tested?

  • 👍 yes, I added tests to the test suite
  • 💭 no, because this PR is a draft and still needs work
  • 🙅 no, because this is not relevant here
  • 🙋 no, because I need help

@berhalak berhalak self-requested a review November 27, 2024 08:36
Copy link
Contributor

@berhalak berhalak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, nitpicking in comments :)

app/client/ui/CustomWidgetGallery.ts Outdated Show resolved Hide resolved
@paulfitz paulfitz added the preview Launch preview deployment of this PR label Nov 27, 2024
@paulfitz
Copy link
Member

(borrowing this PR for a quick preview, don't mind me...)

Copy link
Contributor

Deployed commit 2cb8d0542f68678840b9a5369ae3651e3391c85b as https://grist-gristlabs-grist-core-widget-save-tweak.fly.dev (until 2024-12-27T20:07:48.072Z)

Copy link
Contributor

github-actions bot commented Dec 3, 2024

Deployed commit 58c9f9ae3d781505ed02a361449f088ad2eee583 as https://grist-gristlabs-grist-core-widget-save-tweak.fly.dev (until 2025-01-02T01:24:29.726Z)

@georgegevoian georgegevoian merged commit 40ff38f into main Dec 3, 2024
11 checks passed
@georgegevoian georgegevoian deleted the widget-save-tweak branch December 3, 2024 01:34
@georgegevoian georgegevoian removed the preview Launch preview deployment of this PR label Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants