Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit the errors and warnings mentioning OpenAI #1322

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

fflorent
Copy link
Collaborator

Context

In most cases, Grist uses the OpenAI assistant.
A French user was worried ANCT instance used GPT and therefore sent information to OpenAI. In fact, this instance uses a self-hosted Llama model, thus the message was confusing.

Proposed solution

We instead mention an AI service provider for that sake.

Related issues

It's a rather small change, I did not report an issue. If you feel like it is required, I can open one.

Has this been tested?

  • 👍 yes, I added tests to the test suite
  • 💭 no, because this PR is a draft and still needs work
  • 🙅 no, because this is not relevant here
  • 🙋 no, because I need help

Screenshots / Screencasts

The error message (that this PR changes) the user got and confused him was the following:
image

@fflorent fflorent requested a review from vviers November 25, 2024 14:34
Copy link
Collaborator

@vviers vviers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@paulfitz paulfitz changed the title Edit the errors and warnings mentionning OpenAI Edit the errors and warnings mentioning OpenAI Nov 25, 2024
@paulfitz
Copy link
Member

The substance of this looks fine. There may be a test to update @fflorent.

@fflorent fflorent marked this pull request as ready for review November 25, 2024 16:44
In most cases, Grist uses the OpenAI assistant.
A French user was worried ANCT instance used GPT and therefore sent information to OpenAI. In fact, this instance uses a self-hosted Llama model, thus the message was confusing.

We instead mention an AI service provider for that sake.
Copy link
Member

@paulfitz paulfitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fflorent !

@paulfitz paulfitz merged commit 1be30b9 into gristlabs:main Nov 26, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants