Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a FLATTEN_RECORD_LIST formula #1215

Closed
wants to merge 3 commits into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions sandbox/grist/functions/lookup.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,18 @@ def COLUMNS(range):
"""Returns the number of columns in a specified array or range."""
raise NotImplementedError()

def FLATTEN_RECORDS_LIST(list_of_records, dedup=False):
"""Returns a flat list of records"""
if type(list_of_records) is not list:
raise TypeError("Unexpected Argument, waiting of a list of Records")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wouldn't waiting for a list of Records more English?

if len(list_of_records) == 0:
return list_of_records
flatten_list = [el for val in list_of_records for el in val]
el_type = {el.__class__.__name__ for el in flatten_list}
if list(el_type)[0] != 'Record':
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you have to check the first element only?

Wouldn't 'Record' in el_type be more robust?

return FLATTEN_RECORDS_LIST(flatten_list, dedup)
return list(set(flatten_list)) if dedup else flatten_list

@unimplemented
def GETPIVOTDATA(value_name, any_pivot_table_cell, original_column_1, pivot_item_1=None, *args):
"""Extracts an aggregated value from a pivot table that corresponds to the specified row and column headings."""
Expand Down
Loading