Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump Python version for tests, no longer supporting 3.9 #1112

Merged
merged 1 commit into from
Jul 17, 2024
Merged

bump Python version for tests, no longer supporting 3.9 #1112

merged 1 commit into from
Jul 17, 2024

Conversation

paulfitz
Copy link
Member

After changes for PREVIOUS and related functions, we now depend on new versions of the bisect function.

@paulfitz
Copy link
Member Author

Looks like our pyodide version is already at 3.11.2 (main, Jul 7 2023, 05:19:00) so that part is OK.

@paulfitz
Copy link
Member Author

For grist-desktop, pyodide sandboxing is now the default so that's ok, but if used without sandboxing the version of python is 3.9 so that'll need follow up https://github.com/gristlabs/grist-desktop/blob/6fdda52beb826f128597056e280d8c15c0764e47/scripts/setup.sh#L101

dsagal
dsagal approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@dsagal dsagal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@paulfitz paulfitz marked this pull request as ready for review July 17, 2024 21:42
@paulfitz paulfitz merged commit 4a01c68 into main Jul 17, 2024
11 checks passed
@paulfitz paulfitz deleted the paulfitz/python-3-11 branch July 17, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsagal dsagal dsagal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paulfitz @dsagal