config: make I/O operations synchronous #1110
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original commit messages:
a27eb98 config: replace fse functions with sync variants
I need to be able to read the config at module load time, which makes
async difficult if not impossible.
This will make all config operations synchronous, which is fine. The
file is tiny and seldom read or written to.
3268077 config: remove IReadableConfigValue type
This type is only used to define the IWritableConfigValue type, and
since we are now doing synchronous read and writes, there's no point
in separating get from set.
bfa045b config: remove all async/await around config functions
Now that I/O is synchronous, there's no need to have any more
async/await in regards to the config functions.