Skip to content

Commit

Permalink
ActiveDoc: make Python 3 the default version
Browse files Browse the repository at this point in the history
It's already default in various contexts, but sometimes there is
nothing defining what the Python version, which makes it default to 2.
This has broken some documents in the past. It's high time to change
this default.
  • Loading branch information
jordigh committed Nov 21, 2024
1 parent d169c95 commit da1abbe
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion app/server/lib/ActiveDoc.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2830,7 +2830,7 @@ export class ActiveDoc extends EventEmitter {

private async _makeEngine(): Promise<ISandbox> {
// Figure out what kind of engine we need for this document.
let preferredPythonVersion: '2' | '3' = process.env.PYTHON_VERSION === '3' ? '3' : '2';
let preferredPythonVersion: '2' | '3' = process.env.PYTHON_VERSION === '2' ? '2' : '3';

// Careful, migrations may not have run on this document and it may not have a
// documentSettings column. Failures are treated as lack of an engine preference.
Expand Down

0 comments on commit da1abbe

Please sign in to comment.