Fix docker graceful shutdown (#830)

* run.sh: Replace pid with nodejs's one using exec This notably ensures that "docker stop" sends a TERM signal to the node process which can handle it gracefully and avoid document corruption. * Use exec form for CMD in Dockerfile --------- Co-authored-by: Florent FAYOLLE <[email protected]>
gristlabs · Jan 30, 2024 · 36ade2b · 36ade2b
1 parent f45c53d
commit 36ade2b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/Dockerfile b/Dockerfile
@@ -142,4 +142,4 @@ ENV \
 
 EXPOSE 8484
 
-CMD ./sandbox/run.sh
+CMD ["./sandbox/run.sh"]
diff --git a/sandbox/run.sh b/sandbox/run.sh
@@ -16,4 +16,4 @@ if [[ "$GRIST_SANDBOX_FLAVOR" = "gvisor" ]]; then
   ./sandbox/gvisor/update_engine_checkpoint.sh
 fi
 
-NODE_PATH=_build:_build/stubs:_build/ext node _build/stubs/app/server/server.js
+exec env NODE_PATH=_build:_build/stubs:_build/ext node _build/stubs/app/server/server.js
Original file line number	Diff line number	Diff line change
Expand Up		@@ -142,4 +142,4 @@ ENV \

		EXPOSE 8484

		CMD ./sandbox/run.sh
		CMD ["./sandbox/run.sh"]