Ansi codes now respect indentation #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumped fipp to 0.6.21 to pick up brandonbloom/fipp#66 which resolves greglook#44. To verify, beefed up ansi unit tests to include a test that almost matches example in puget README and a test that clearly shows indentation. Of note: While developing these tests I used kaocha because it has excellent expected vs actual diff reporting. Because kaocha uses puget, I figured it might not be the best idea to use kaocha for puget testing and therefore have not proposed to include it.
Codecov Report
@@ Coverage Diff @@
## develop #46 +/- ##
===========================================
+ Coverage 99.3% 99.53% +0.23%
===========================================
Files 5 5
Lines 431 431
Branches 1 1
===========================================
+ Hits 428 429 +1
+ Misses 2 1 -1
Partials 1 1
Continue to review full report at Codecov.
|
greglook
approved these changes
Oct 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumped fipp to 0.6.21 to pick up brandonbloom/fipp#66
which resolves #44.
To verify, beefed up ansi unit tests to include a test that almost matches
example in puget README and a test that clearly shows indentation.
Of note: While developing these tests I used kaocha because it has excellent
expected vs actual diff reporting. Because kaocha uses puget, I figured it might
not be the best idea to use kaocha for puget testing and therefore have not
proposed to include it.