Add style handling via .editorconfig and .clang-format #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most editors support the config format out of the box and with some patches in the works, it's great to have something in-tree to avoid (further) mixing the style. The format is sufficient to handle basic indentation size/style and line length. More elaborate style tracking can be done with clang-format... incoming with a later patch. Signed-off-by: Emil Velikov <[email protected]>
Signed-off-by: Emil Velikov <[email protected]>
Swap kernel list of for_each macros for what we actually use in-tree. Signed-off-by: Emil Velikov <[email protected]>
It will help enforce the style defined in .clang-format, only for newly introduced changes. Pre-existing style issues will not be flagged, unless the lines are changed with given commit. If a particular section needs to be ignored, it should be wrapped in clang-format off/on section. Signed-off-by: Emil Velikov <[email protected]>
|
Thanks for these, no major objections but I bumped the max line length in the editorconfig file I've merged these "by hand", to go around the build check, but all are now applied. |
|
Thanks, glad it wasn't too controversial. Fwiw the CI is failing due to the missing Copyright for |
|
All now fixed up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generally such topics are highly volatile, so grab as many/little as you prefer while I hide from the incoming rotten tomatoes
This PR adds the two configuration files, alongside a CI workflow which helps getting consistent style for new changes.
The existing code is untouched - if you want to mass update the repo be my guest. If you do, adding the commit sha in
.git-blame-ignore-revswill keepgit blameworking OOTB with Github/Gitlab, while devs will have togit configit (seegit-blame(1)).Notes:
.clang-formatis coming from the kernel, yet lacks any copyright attributionclang-formatsometimes reorders multi-line enums/initializers - a trailing comma for final entry usually solves itclang-format offcomment and re-enabled withclang-format on