chore: upgrade cosmiconfig #905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Also, here's the release notes for cosmiconfig 8.3.6 with details about the bug: https://github.com/cosmiconfig/cosmiconfig/releases/tag/cosmiconfig-v8.3.6 |
Codecov Report
@@ Coverage Diff @@
## main #905 +/- ##
=======================================
Coverage 92.89% 92.89%
=======================================
Files 32 32
Lines 760 760
Branches 251 255 +4
=======================================
Hits 706 706
Misses 53 53
Partials 1 1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Upgrade to cosmiconfig 8.3.6, which fixes an unhandled exception when traversing parent directories looking for directories named
.config. If a parent directory contained a file named.config, before this fix, generated React apps would fail to start. I documented this bug in facebook/create-react-app#13355 (comment) but I believe the issue originates from within this library.Test plan
I followed the steps documented in CONTRIBUTING.md.
pnpm installpnpm run devstill workspnpm run lintpasses (All matched files use Prettier code style!)pnpm run testsucceeds (245 passed, 245 total)