Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLANET-6692: Remove block editor validation feature from the plugin #1266

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mardelnet
Copy link
Contributor

Summary

This PR removes the editor validation feature from the plugin in order to move it to the master theme.
As the new Topic Link block requires the addition of a background image as mandatory (check comments here) which depends on the editor validation feature, and considering that we plan to completely remove the P4 plugin, the previously mentioned feature was moved to the master theme here.


Ref: https://jira.greenpeace.org/browse/PLANET-6692

Testing

  1. Locally, create a new or edit a Post, and add a Topic Link block.
  2. Or use the following link.
  3. Check whether the post cannot be published if no title, no featured images, or no background image to any Topic Link blocks is added.

- Remove block editor validation feature from plugin
@mardelnet mardelnet requested a review from mleray December 16, 2024 09:51
@mardelnet mardelnet self-assigned this Dec 16, 2024
@mardelnet mardelnet changed the title Remove block editor validation feature from the plugin PLANET-6692: Remove block editor validation feature from the plugin Dec 16, 2024
planet-4 added a commit to greenpeace/planet4-test-pluto that referenced this pull request Dec 16, 2024
/unhold 63bca224-e065-44ad-8507-b045b07fb074
@planet-4
Copy link
Contributor

Test instance is ready 🚀

🌑 pluto | admin | blocks report | CircleCI | composer-local.json

⌚ 2024.12.16 10:17:52

Copy link
Contributor

@mleray mleray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants