Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLANET-7646 Add placeholder image to Author block #2489

Merged
merged 2 commits into from
Jan 14, 2025

Conversation

sagarsdeshmukh
Copy link
Member

@sagarsdeshmukh sagarsdeshmukh commented Dec 26, 2024

Summary

if the author image is not available show MistryPerson(mm) avatar image
Ref: PLANET-7646

Testing

Please check the author image at the bottom of the post -
https://www-dev.greenpeace.org/test-tavros/story/1383/test-author-profile-image/

Same issue also fixed for author page

@sagarsdeshmukh sagarsdeshmukh added Review UAT Needed This PR requires User Acceptance Tests before merge labels Dec 26, 2024
@sagarsdeshmukh sagarsdeshmukh requested review from GP-Dan-Tovbein and a team December 26, 2024 09:54
@sagarsdeshmukh sagarsdeshmukh self-assigned this Dec 26, 2024
@sagarsdeshmukh sagarsdeshmukh requested review from mleray and removed request for a team December 26, 2024 09:54
@sagarsdeshmukh sagarsdeshmukh force-pushed the PLANET-7646_fix_author_img branch from 4d46380 to cbbb5ab Compare December 26, 2024 09:57
planet-4 added a commit to greenpeace/planet4-test-tavros that referenced this pull request Dec 26, 2024
/unhold 06e67f05-a64b-4adb-9dd9-d3837d84a50a
@planet-4
Copy link
Contributor

planet-4 commented Dec 26, 2024

Test instance is ready 🚀

🌑 tavros | admin | blocks report | CircleCI | composer-local.json

⌚ 2025.01.13 13:54:35

Copy link
Contributor

@mleray mleray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👏

If author image is not available show MistryPerson(mm) avatar image
@sagarsdeshmukh sagarsdeshmukh force-pushed the PLANET-7646_fix_author_img branch from cbbb5ab to b59a2d2 Compare January 13, 2025 12:23
planet-4 added a commit to greenpeace/planet4-test-tavros that referenced this pull request Jan 13, 2025
/unhold fa87290a-eb3d-41f8-9d7b-8153addccefa
@sagarsdeshmukh sagarsdeshmukh requested a review from mleray January 13, 2025 13:46
planet-4 added a commit to greenpeace/planet4-test-tavros that referenced this pull request Jan 13, 2025
/unhold 7d0f9410-50a6-46b1-af2c-581a82db3b32
// Default avatar.
if (defined('WP_DEBUG') && WP_DEBUG === true) {
// Gravatar throws an error for local dev default_avatar URL, so the default value is used.
$context['default_avatar'] = 'mm'; //Mystery Man
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for commenting that it stands for "Mystery Man", I wouldn't have guessed 😂

Copy link
Contributor

@mleray mleray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👏

@comzeradd comzeradd added UAT Passed User Acceptance Tests passed and removed UAT Needed This PR requires User Acceptance Tests before merge labels Jan 14, 2025
@sagarsdeshmukh sagarsdeshmukh merged commit 3b9648b into main Jan 14, 2025
15 checks passed
@sagarsdeshmukh sagarsdeshmukh deleted the PLANET-7646_fix_author_img branch January 14, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Review [Test Env] tavros UAT Passed User Acceptance Tests passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants