Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLANET-7635 Move remaining code from plugin #2483

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

mleray
Copy link
Contributor

@mleray mleray commented Dec 18, 2024

Description

See PLANET-7635

Moved code:

Other changes

  • Removed last uses of p4bk_vars
  • Wait for DOM content to be loaded before using frontend functions in app.js

@mleray mleray self-assigned this Dec 18, 2024
planet-4 added a commit to greenpeace/planet4-test-titan that referenced this pull request Dec 18, 2024
/unhold fa41d8a9-8b7d-4dac-a210-1c1beff7f362
planet-4 added a commit to greenpeace/planet4-test-titan that referenced this pull request Dec 18, 2024
/unhold 600b91e4-0af2-4943-8b1f-2efd4982d0ff
planet-4 added a commit to greenpeace/planet4-test-titan that referenced this pull request Dec 18, 2024
/unhold ba88e203-4e03-4a37-9697-60664f3321cc
@planet-4
Copy link
Contributor

planet-4 commented Dec 18, 2024

Test instance is ready 🚀

🌑 titan | admin | blocks report | CircleCI | composer-local.json

⌚ 2025.01.06 11:07:24

planet-4 added a commit to greenpeace/planet4-test-titan that referenced this pull request Dec 18, 2024
/unhold 21dc9923-08b4-42a2-a8ce-e4c03787cd01
@mleray mleray force-pushed the plugin-retirement branch 2 times, most recently from a67d320 to f643e97 Compare December 18, 2024 14:56
planet-4 added a commit to greenpeace/planet4-test-titan that referenced this pull request Dec 18, 2024
/unhold aefb8362-e8ba-4cf9-a778-05e8a5fe5898
planet-4 added a commit to greenpeace/planet4-test-titan that referenced this pull request Dec 18, 2024
/unhold e7ca49ea-424a-4b4b-9f0c-187c20179cb4
planet-4 added a commit to greenpeace/planet4-test-titan that referenced this pull request Dec 18, 2024
/unhold a81dcfe8-f6a4-45dc-9a00-1be5f0489e6f
planet-4 added a commit to greenpeace/planet4-test-titan that referenced this pull request Dec 18, 2024
/unhold 15c9f992-8501-459c-bf82-325d11d93fa6
planet-4 added a commit to greenpeace/planet4-test-titan that referenced this pull request Dec 18, 2024
/unhold 122a1fc2-04e1-43df-babe-8e5b3638925c
@mleray mleray force-pushed the plugin-retirement branch 2 times, most recently from 925c4a3 to 447ecf7 Compare December 18, 2024 15:50
planet-4 added a commit to greenpeace/planet4-test-titan that referenced this pull request Dec 18, 2024
/unhold 684c4a03-dbf6-418c-89ec-7999c59fd837
planet-4 added a commit to greenpeace/planet4-test-titan that referenced this pull request Dec 18, 2024
/unhold b4e119b3-104b-4798-af3b-89778ea1c25b
planet-4 added a commit to greenpeace/planet4-test-titan that referenced this pull request Dec 18, 2024
/unhold d0ff754a-d777-4fb8-9f3e-9abe12e5ae16
planet-4 added a commit to greenpeace/planet4-test-titan that referenced this pull request Dec 18, 2024
/unhold 7347750d-5a3b-474e-b1e6-ea2b6def96f2
planet-4 added a commit to greenpeace/planet4-test-titan that referenced this pull request Dec 19, 2024
/unhold 35b47c4d-999b-4091-9501-8580581ef8d7
planet-4 added a commit to greenpeace/planet4-test-titan that referenced this pull request Dec 19, 2024
/unhold 9975848d-3d9f-4d9b-a2d6-626067514ecd
planet-4 added a commit to greenpeace/planet4-test-titan that referenced this pull request Dec 19, 2024
/unhold f0a721a4-dbff-4449-ba3b-9b0b32b7aea1
planet-4 added a commit to greenpeace/planet4-test-titan that referenced this pull request Dec 19, 2024
/unhold 30071594-cdf0-4131-9217-f2a8a2da63b1
@mleray mleray marked this pull request as ready for review December 19, 2024 13:26
@mleray mleray requested review from GP-Dan-Tovbein, a team and sagarsdeshmukh and removed request for a team December 19, 2024 13:27
@mleray mleray added the Review label Dec 19, 2024
planet-4 added a commit to greenpeace/planet4-test-titan that referenced this pull request Dec 19, 2024
/unhold 1668ab2f-b6dd-43b2-a08a-3ee8fdfc807b
@mleray mleray force-pushed the plugin-retirement branch 2 times, most recently from da0a6a3 to 308be28 Compare December 19, 2024 13:36
planet-4 added a commit to greenpeace/planet4-test-titan that referenced this pull request Dec 19, 2024
/unhold b073d1f7-f1bc-40a2-a07f-07b4ce446c99
planet-4 added a commit to greenpeace/planet4-test-titan that referenced this pull request Dec 19, 2024
/unhold 67bf295f-9850-4db2-8990-5742ed3ff972
@mleray mleray force-pushed the plugin-retirement branch 2 times, most recently from c5fecfb to 5f91ebd Compare December 19, 2024 14:54
This is in preparation to finally retire it
planet-4 added a commit to greenpeace/planet4-test-titan that referenced this pull request Dec 19, 2024
/unhold 5a8c944e-d464-45fb-b637-a71478c8f77d
This was set in the plugin but in the theme we use p4_vars
planet-4 added a commit to greenpeace/planet4-test-titan that referenced this pull request Jan 6, 2025
/unhold 5cbc8981-3b81-4dbc-a62b-d86c88309ada
planet-4 added a commit to greenpeace/planet4-test-titan that referenced this pull request Jan 6, 2025
/unhold f39dea2e-a3d2-457d-a703-99c76ebdbe43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants