-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PLANET-7635 Move remaining code from plugin #2483
Open
mleray
wants to merge
3
commits into
main
Choose a base branch
from
plugin-retirement
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+1,416
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mleray
force-pushed
the
plugin-retirement
branch
from
December 18, 2024 14:14
7bdcdda
to
6bb6fea
Compare
planet-4
added a commit
to greenpeace/planet4-test-titan
that referenced
this pull request
Dec 18, 2024
/unhold fa41d8a9-8b7d-4dac-a210-1c1beff7f362
mleray
force-pushed
the
plugin-retirement
branch
from
December 18, 2024 14:19
6bb6fea
to
6f8692b
Compare
planet-4
added a commit
to greenpeace/planet4-test-titan
that referenced
this pull request
Dec 18, 2024
/unhold 600b91e4-0af2-4943-8b1f-2efd4982d0ff
mleray
force-pushed
the
plugin-retirement
branch
from
December 18, 2024 14:28
6f8692b
to
290f771
Compare
planet-4
added a commit
to greenpeace/planet4-test-titan
that referenced
this pull request
Dec 18, 2024
/unhold ba88e203-4e03-4a37-9697-60664f3321cc
Test instance is ready 🚀🌑 titan | admin | blocks report | CircleCI | composer-local.json ⌚ 2025.01.06 11:07:24 |
mleray
force-pushed
the
plugin-retirement
branch
from
December 18, 2024 14:40
290f771
to
4b216e9
Compare
planet-4
added a commit
to greenpeace/planet4-test-titan
that referenced
this pull request
Dec 18, 2024
/unhold 21dc9923-08b4-42a2-a8ce-e4c03787cd01
mleray
force-pushed
the
plugin-retirement
branch
2 times, most recently
from
December 18, 2024 14:56
a67d320
to
f643e97
Compare
planet-4
added a commit
to greenpeace/planet4-test-titan
that referenced
this pull request
Dec 18, 2024
/unhold aefb8362-e8ba-4cf9-a778-05e8a5fe5898
mleray
force-pushed
the
plugin-retirement
branch
from
December 18, 2024 15:14
f643e97
to
0d1ff16
Compare
planet-4
added a commit
to greenpeace/planet4-test-titan
that referenced
this pull request
Dec 18, 2024
/unhold e7ca49ea-424a-4b4b-9f0c-187c20179cb4
mleray
force-pushed
the
plugin-retirement
branch
from
December 18, 2024 15:27
0d1ff16
to
0088adb
Compare
planet-4
added a commit
to greenpeace/planet4-test-titan
that referenced
this pull request
Dec 18, 2024
/unhold a81dcfe8-f6a4-45dc-9a00-1be5f0489e6f
mleray
force-pushed
the
plugin-retirement
branch
from
December 18, 2024 15:41
0088adb
to
239889e
Compare
planet-4
added a commit
to greenpeace/planet4-test-titan
that referenced
this pull request
Dec 18, 2024
/unhold 15c9f992-8501-459c-bf82-325d11d93fa6
mleray
force-pushed
the
plugin-retirement
branch
from
December 18, 2024 15:43
239889e
to
bb5f420
Compare
planet-4
added a commit
to greenpeace/planet4-test-titan
that referenced
this pull request
Dec 18, 2024
/unhold 122a1fc2-04e1-43df-babe-8e5b3638925c
mleray
force-pushed
the
plugin-retirement
branch
2 times, most recently
from
December 18, 2024 15:50
925c4a3
to
447ecf7
Compare
planet-4
added a commit
to greenpeace/planet4-test-titan
that referenced
this pull request
Dec 18, 2024
/unhold 684c4a03-dbf6-418c-89ec-7999c59fd837
planet-4
added a commit
to greenpeace/planet4-test-titan
that referenced
this pull request
Dec 18, 2024
/unhold b4e119b3-104b-4798-af3b-89778ea1c25b
planet-4
added a commit
to greenpeace/planet4-test-titan
that referenced
this pull request
Dec 18, 2024
/unhold d0ff754a-d777-4fb8-9f3e-9abe12e5ae16
mleray
force-pushed
the
plugin-retirement
branch
from
December 18, 2024 16:36
48c2771
to
ec06f4d
Compare
planet-4
added a commit
to greenpeace/planet4-test-titan
that referenced
this pull request
Dec 18, 2024
/unhold 7347750d-5a3b-474e-b1e6-ea2b6def96f2
mleray
force-pushed
the
plugin-retirement
branch
from
December 18, 2024 16:41
ec06f4d
to
001aaf2
Compare
planet-4
added a commit
to greenpeace/planet4-test-titan
that referenced
this pull request
Dec 19, 2024
/unhold 35b47c4d-999b-4091-9501-8580581ef8d7
mleray
force-pushed
the
plugin-retirement
branch
from
December 19, 2024 12:24
2baead9
to
5e83a31
Compare
planet-4
added a commit
to greenpeace/planet4-test-titan
that referenced
this pull request
Dec 19, 2024
/unhold 9975848d-3d9f-4d9b-a2d6-626067514ecd
mleray
force-pushed
the
plugin-retirement
branch
from
December 19, 2024 12:31
5e83a31
to
aa35a13
Compare
planet-4
added a commit
to greenpeace/planet4-test-titan
that referenced
this pull request
Dec 19, 2024
/unhold f0a721a4-dbff-4449-ba3b-9b0b32b7aea1
mleray
force-pushed
the
plugin-retirement
branch
from
December 19, 2024 13:16
aa35a13
to
f18b020
Compare
planet-4
added a commit
to greenpeace/planet4-test-titan
that referenced
this pull request
Dec 19, 2024
/unhold 30071594-cdf0-4131-9217-f2a8a2da63b1
mleray
requested review from
GP-Dan-Tovbein,
a team and
sagarsdeshmukh
and removed request for
a team
December 19, 2024 13:27
mleray
force-pushed
the
plugin-retirement
branch
from
December 19, 2024 13:31
f18b020
to
3af9134
Compare
planet-4
added a commit
to greenpeace/planet4-test-titan
that referenced
this pull request
Dec 19, 2024
/unhold 1668ab2f-b6dd-43b2-a08a-3ee8fdfc807b
mleray
force-pushed
the
plugin-retirement
branch
2 times, most recently
from
December 19, 2024 13:36
da0a6a3
to
308be28
Compare
planet-4
added a commit
to greenpeace/planet4-test-titan
that referenced
this pull request
Dec 19, 2024
/unhold b073d1f7-f1bc-40a2-a07f-07b4ce446c99
mleray
force-pushed
the
plugin-retirement
branch
from
December 19, 2024 14:45
308be28
to
eb7f1cd
Compare
planet-4
added a commit
to greenpeace/planet4-test-titan
that referenced
this pull request
Dec 19, 2024
/unhold 67bf295f-9850-4db2-8990-5742ed3ff972
mleray
force-pushed
the
plugin-retirement
branch
2 times, most recently
from
December 19, 2024 14:54
c5fecfb
to
5f91ebd
Compare
This is in preparation to finally retire it
mleray
force-pushed
the
plugin-retirement
branch
from
December 19, 2024 14:56
5f91ebd
to
576647a
Compare
planet-4
added a commit
to greenpeace/planet4-test-titan
that referenced
this pull request
Dec 19, 2024
/unhold 5a8c944e-d464-45fb-b637-a71478c8f77d
This was set in the plugin but in the theme we use p4_vars
planet-4
added a commit
to greenpeace/planet4-test-titan
that referenced
this pull request
Jan 6, 2025
/unhold 5cbc8981-3b81-4dbc-a62b-d86c88309ada
This is causing issues otherwise
planet-4
added a commit
to greenpeace/planet4-test-titan
that referenced
this pull request
Jan 6, 2025
/unhold f39dea2e-a3d2-457d-a703-99c76ebdbe43
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See PLANET-7635
Moved code:
Other changes
p4bk_vars
app.js