PoC for preloading responsive images for blocks #2322
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Testing out the functionality using the Carousel Block
planet-4
added a commit
to greenpeace/planet4-test-umbriel
that referenced
this pull request
Jul 15, 2024
/unhold b99353a7-ba97-43e8-84f9-0ef937b31f73
Test instance is ready 🚀🌑 umbriel | admin | blocks report | CircleCI | composer-local.json ⌚ 2024.07.15 09:41:10 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: PoC for Preloading big images (eg. Carousel Header, Page Header pattern) while using imagesrcset.
Still a work in progress. I need to understand certain things as regards testing on different screen sizes.
The concept seems straight forward but testing wise, I still seem to load the same image despite the it been on different screen sizes.
Some implementations propose using
<link rel="preload" as="image" href="images/example-medium.jpg" media="(max-width: 1023px)">, while others suggest replacing themediawith asizesattribute instead. Still need to test further and see which implementation best works for our code base