-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move loading of custom HTML headers and static assets #49
Move loading of custom HTML headers and static assets #49
Conversation
@poettig , this looks good! Thank you! Please add CLA |
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
@poettig , please see here how to agree to CLA. https://github.com/contributor-assistant/github-action#demo-for-step-2-and-3 |
76de1e7
to
f2a090f
Compare
I have read the CLA Document and I hereby sign the CLA |
@greenpau Sorry, I overlooked the CONTRIBUTING.md and then had to clean up / rebase with upstream on this branch first. It should be all cleared up now :) |
@poettig , please follow https://github.com/greenpau/go-authcrunch/blob/main/CONTRIBUTING.md#contributor-license-agreements. 2 requirements. Apologies for the confusion. Once it is done, I will merge and release |
@greenpau No worries, I should have read CONTRIBUTING.md again after rebasing. I followed the steps and added my consent to the yml. |
@poettig , thank you for contributing 👍 |
This change is necessary for greenpau/caddy-security#290, further explanation over there.
It loads custom HTML headers and static assets at the same time that
custom js path
andcustom css path
get loaded instead of arbitrarily loading them when reading the Caddyfile incaddy-security
.