Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow adding fields from user info #44

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Allow adding fields from user info #44

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2eb2cea
Allow adding fields from user info
MartinWallgren Apr 19, 2023
d8ca2d6
Consent to individual CLA
MartinWallgren Apr 19, 2023
88b193a
Merge branch 'main' into main
greenpau Sep 4, 2023
3659994
Merge branch 'main' into main
greenpau Dec 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions assets/cla/consent.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,5 +37,7 @@
email: [email protected]
- name: Riccardo Piola
email: [email protected]
- name: Martin Wallgren
email: [email protected]
- name: Nick Gregory
email: [email protected]
9 changes: 8 additions & 1 deletion pkg/idp/oauth/validator.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import (
jwtlib "github.com/golang-jwt/jwt/v4"
"github.com/greenpau/go-authcrunch/pkg/errors"
"github.com/greenpau/go-authcrunch/pkg/kms"
"go.uber.org/zap"
"strings"
)

Expand Down Expand Up @@ -96,8 +97,14 @@ func (b *IdentityProvider) validateAccessToken(state string, data map[string]int
return nil, errors.ErrIdentityProviderOAuthEmailNotFound.WithArgs(b.config.IdentityTokenName)
}
}

m := make(map[string]interface{})
for k, v := range claims {
if _, exists := b.userInfoFields[k]; exists {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MartinWallgren , thank you for the contribution. What is the effect of this? Is it possible to only add "select" fields as opposed to everything?

b.logger.Debug("Add user info field.", zap.String(k, fmt.Sprintf("%v", v)))
m[k] = v
}
}

for _, k := range tokenFields {
if _, exists := claims[k]; !exists {
continue
Expand Down