Various internal improvements #51
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notify-send allows to set a parameter multiple times, but take the last one precedence. Therefore we can dedup most of the stuff by setting the default values (and let it override by special call).
For rationale see the shellcheck wiki: https://github.com/koalaman/shellcheck/wiki/SC2086
graysky2
force-pushed
the
master
branch
2 times, most recently
from
6242df0 to
4115a1c
Compare
graysky2
force-pushed
the
master
branch
3 times, most recently
from
bb1dbd9 to
1eb2a0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I went over the code after doing #49. Here are some internal improvements on the code.
Mostly, this is code deduplication and some shellcheck stuff.