feat(List): improve a11y #960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is ready. |
ogonkov
reviewed
Aug 28, 2023
amje
requested changes
Aug 28, 2023
korvin89
requested changes
Aug 28, 2023
korvin89
reviewed
Sep 6, 2023
There was a problem hiding this comment.
Do we actually need this logic if we use List selection api?
|
In the List component, any type of selection (single or multiple) is represented with orange highlighting. In the Select component, single selection is also displayed as orange highlighting, while multiple selection is indicated by a checkbox icon. As a result, in the Select component, we disable the styles used for selection in the List and apply our custom styles. All the logic related to the selected option is also contained within the Select component. We pass the indexes of the selected options to the List to correctly set the aria-selected attribute. So, this logic is still required. |
korvin89
approved these changes
Sep 8, 2023
amje
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #686