refactor(Toaster): fix incompatibility of different Toaster APIs #1987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is ready. |
|
Visual Tests Report is ready. |
icekimi23
force-pushed
the
refactor/Toaster
branch
from
9d04f6b to
e788ad6
Compare
ogonkov
reviewed
Dec 17, 2024
| remove(name: string) { | ||
| this.toasts = removeToast(this.toasts, name); | ||
|
|
||
| this.notify(); | ||
| } |
There was a problem hiding this comment.
I think we need to maintain destroy() method, let it call removeAll underneath
|
|
||
| import {ToasterContext} from './ToasterContext'; | ||
| import {ToastsContext} from './ToastsContext'; | ||
|
|
||
| type Props = React.PropsWithChildren<{}>; | ||
| type Props = React.PropsWithChildren<{ | ||
| toaster: ToasterSingleton; |
There was a problem hiding this comment.
This is definitely breaking change, please change target branch to next
Comment on lines
+94
to
98
| private notify() { | ||
| for (const listener of this.listeners) { | ||
| listener(this.toasts); | ||
| } | ||
| } |
There was a problem hiding this comment.
Please separate subscribe pattern from Toaster class to separate base class EventEmitter
|
Please describe all breaking changes in PR description |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR is made to implement this RFC gravity-ui/rfc#15