-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Label): implement css api #1953
base: main
Are you sure you want to change the base?
Conversation
Preview is ready. |
Visual Tests Report is ready. |
@goshander do i need to add css api for addons? as i understand it, margin for addons is not calculated now |
@@ -159,3 +159,30 @@ export const ShowcaseStory: Story = { | |||
render: () => <LabelShowcase />, | |||
name: 'Showcase', | |||
}; | |||
|
|||
export const Custom: Story = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Custom story is visually broken now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Custom story is visually broken now
please tell me in more detail what needs to be fixed in this story?
src/components/Label/Label.scss
Outdated
display: flex; | ||
align-items: baseline; | ||
margin: 0 var(--_--margin-inline); | ||
margin: 0 var(--g-label-margin-inline, var(--_--margin-inline)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can me named --g-label-padding
like in Button's CSS API to be consistent, maybe also change prop from margin to padding
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can me named
--g-label-padding
like in Button's CSS API to be consistent, maybe also change prop from margin to padding
should I definitely change margin to padding? with padding, margin will be larger due to collapse margins
resolved #1905