feat(Popup)!: migrate to floating-ui #1952
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visual Tests Report is ready. |
|
Preview is ready. |
amje
requested changes
Nov 15, 2024
oynikishin
force-pushed
the
feat/popup-migrate-to-foating-ui
branch
from
92adbdd to
35e6b09
Compare
amje
approved these changes
Nov 19, 2024
oynikishin
requested review from
IsaevAlexandr,
Raubzeug,
korvin89,
kseniya57 and
ValeraS
as code owners
Raubzeug
approved these changes
Nov 20, 2024
korvin89
approved these changes
Nov 20, 2024
ValeraS
requested changes
Nov 20, 2024
oynikishin
force-pushed
the
feat/popup-migrate-to-foating-ui
branch
from
35e6b09 to
2a980d7
Compare
|
Add changes to FilePreview because without them the tests would not run locally also set default placement for DropdownMenuPopup because default Popup placement is now |
ValeraS
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.