Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(useBodyScrollLock): correctly restore styles #1950

Merged
merged 2 commits into from
Nov 14, 2024
Merged

fix(useBodyScrollLock): correctly restore styles #1950

merged 2 commits into from
Nov 14, 2024

Conversation

sofiushko
Copy link
Contributor

No description provided.

@gravity-ui-bot
Copy link
Contributor

Preview is ready.

@gravity-ui-bot
Copy link
Contributor

Visual Tests Report is ready.

@korvin89
Copy link
Contributor

What problem was here?

@sofiushko
Copy link
Contributor Author

What problem was here?

CSSStyleDeclaration.removeProperty() not working with properties in camelCase
https://developer.mozilla.org/en-US/docs/Web/API/CSSStyleDeclaration/removeProperty#property

So restoreBodyStyles() was broken

@sofiushko sofiushko merged commit b41a53a into gravity-ui:main Nov 14, 2024
6 checks passed
@gravity-ui-bot gravity-ui-bot mentioned this pull request Nov 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korvin89 korvin89 korvin89 approved these changes

@amje amje Awaiting requested review from amje amje is a code owner

@ValeraS ValeraS Awaiting requested review from ValeraS ValeraS is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sofiushko @gravity-ui-bot @korvin89