Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(PlaceholderContainer): remove href attribute fallback in actions #1947

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

lxndr
Copy link
Contributor

@lxndr lxndr commented Nov 13, 2024

Closes #1946

@lxndr lxndr requested a review from Marginy605 as a code owner November 13, 2024 19:10
@gravity-ui-bot
Copy link
Contributor

Visual Tests Report is ready.

@gravity-ui-bot
Copy link
Contributor

Preview is ready.

@lxndr lxndr force-pushed the fix/placeholdercontainer-actions-are-always-links branch from 4c07655 to 07b5496 Compare November 14, 2024 10:22
@lxndr lxndr changed the title fix(PlaceholderContainer): actions should be buttons if no href speci… fix(PlaceholderContainer): remove href attribute fallback in actions Nov 14, 2024
@lxndr lxndr merged commit 60a8b92 into main Nov 14, 2024
8 checks passed
@lxndr lxndr deleted the fix/placeholdercontainer-actions-are-always-links branch November 14, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PlaceholderContainer: actions are always links
3 participants