feat(PasswordInput): add component #1745
Conversation
|
Preview is ready. |
|
Visual Tests Report is ready. |
src/components/controls/PasswordInput/__tests__/PasswordInput.visual.test.tsx
Outdated
Show resolved
Hide resolved
| }, []); | ||
|
|
||
| return ( | ||
| <div className={b()}> |
There was a problem hiding this comment.
Use Flex component, no need to add className or any styles
| @@ -0,0 +1,7 @@ | |||
| .password-input-stories { | |||
There was a problem hiding this comment.
Can be done without styles, see message above
There was a problem hiding this comment.
deleted this style file
| import en from './en.json'; | ||
| import ru from './ru.json'; | ||
|
|
||
| const COMPONENT = 'passwordInput'; |
There was a problem hiding this comment.
| const COMPONENT = 'passwordInput'; | |
| const COMPONENT = 'PasswordInput'; |
|
|
||
| import {PasswordInputStories} from './helpersPlaywright'; | ||
|
|
||
| test.describe('PasswordInputStories', () => { |
There was a problem hiding this comment.
| test.describe('PasswordInputStories', () => { | |
| test.describe('PasswordInput', () => { |
NasgulNexus
force-pushed
the
password-input
branch
from
8a202ae to
131354b
Compare
|
@ValeraS Hi, can you take a look? |
| const additionalEndContent = ( | ||
| <React.Fragment> | ||
| {endContent || rightContent} | ||
| {inputValue && showCopyButton ? ( |
There was a problem hiding this comment.
| {inputValue && showCopyButton ? ( | |
| {inputValue && showCopyButton && !props.disabled ? ( |
There was a problem hiding this comment.
as for me, the disable should only restrict the input of a value, copying is blocked separately
There was a problem hiding this comment.
Disabled controls are not interactive. If you need to interact with a control without the ability to edit it, there is a readOnly property for that.
| const onClick = () => { | ||
| setHideValue((hideValue) => !hideValue); | ||
| }; |
|
@NasgulNexus hey, can you look back to this issue, please? |
|
@ValeraS Hi! Corrected comments added revealValue |
NasgulNexus
force-pushed
the
password-input
branch
from
71774aa to
c9643fc
Compare
| const {actionButtonSize, iconSize} = getActionButtonSizeAndIconSize(size); | ||
|
|
||
| const onClick: React.MouseEventHandler<HTMLButtonElement> = (event) => { | ||
| event.preventDefault(); |
There was a problem hiding this comment.
preventDefault should be on mouse down
| hasCopyTooltip = true, | ||
| hasRevealTooltip = true, |
There was a problem hiding this comment.
I suggest
- to rename
hasCopyTooltiptoshowCopyTooltipand remove default. I think there is no need in this element by default - to rename
hasRevealTooltiptoshowRevealTooltipand remove default. I think we can hide this eleement by default
|
@NasgulNexus @ValeraS @amje please, come back to this PR. |
amje
changed the title
No description provided.