feat: add DefinitionList and HelpMark #1731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is ready. |
|
Visual Tests Report is ready. |
Raubzeug
force-pushed
the
add-definition-list
branch
from
82c4a7e to
02cb48e
Compare
amje
requested changes
Oct 1, 2024
amje
requested changes
Oct 10, 2024
amje
requested changes
Oct 15, 2024
| if (isItem) { | ||
| normalizedItems.push(item); | ||
| } else { | ||
| warnOnce('Only <DefinitionList.Item> components is allowed inside <DefinitionList>'); |
There was a problem hiding this comment.
Suggested change
| warnOnce('Only <DefinitionList.Item> components is allowed inside <DefinitionList>'); | |
| warnOnce('[DefinitionList] Only <DefinitionList.Item> components is allowed as children'); |
| @@ -0,0 +1,2 @@ | |||
| export {DefinitionList} from './DefinitionList'; | |||
There was a problem hiding this comment.
Let's reexport DefinitionListItem component as well. There might be issues with dot notation in Next.js applications
src/components/HelpMark/README.md
Outdated
|
|
||
| ## Properties | ||
|
|
||
| | Property | Type | Required | Default | Description | |
There was a problem hiding this comment.
Let's use columns in this order and names: Name, Description, Type, Default, no Required column, Type and Default should be center aligned
amje
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.