-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Avatar): add 2xs Avatar size #1721
Merged
Merged
Changes from 11 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
606bab1
feat(Avatar): add 2xs Avatar size
PahaN47 d49c17c
fix(Avatar): showcase visual tests
PahaN47 146d298
feat(User): add 2xs size
PahaN47 194ddb8
Merge branch 'main' into avatar-2xs
PahaN47 627c2f9
chore: fix lint
PahaN47 c3aa5e0
Merge branch 'main' into avatar-2xs
PahaN47 c40fe81
fix: css code style
PahaN47 80d468d
Merge branch 'main' into avatar-2xs
PahaN47 b4c2e5e
fix: added css api
PahaN47 614aaf3
fix: tests
PahaN47 277b548
Merge branch 'main' into avatar-2xs
PahaN47 f899e6d
Merge branch 'main' into avatar-2xs
PahaN47 9aa79bc
fix: code style
PahaN47 6e4cb0b
Merge branch 'main' into avatar-2xs
PahaN47 3cee714
Merge branch 'main' into avatar-2xs
PahaN47 d3cf87e
fix: text size
PahaN47 264c96e
Merge branch 'main' into avatar-2xs
PahaN47 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
+10.1 KB
(110%)
...tar.visual.test.tsx-snapshots/Avatar-render-story-Showcase-1-chromium-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
+4.87 KB
(110%)
...vatar.visual.test.tsx-snapshots/Avatar-render-story-Showcase-1-webkit-linux.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
@use 'sass:map'; | ||
|
||
$sizes: ( | ||
'2xs': 20px, | ||
'xs': 24px, | ||
's': 28px, | ||
'm': 32px, | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -28,21 +28,23 @@ LANDING_BLOCK--> | |
|
||
## Size | ||
|
||
To control the size of the `User` use the `size` property. The default size is `m`. Possible values: `xs`, `s`, `m`, `l`, `xl`. | ||
To control the size of the `User` use the `size` property. The default size is `m`. Possible values: `2xs`, `xs`, `s`, `m`, `l`, `xl`. | ||
|
||
This propeperty passes to the internal `Avatar` component too. | ||
|
||
<!--LANDING_BLOCK | ||
|
||
<ExampleBlock | ||
code={` | ||
<User avatar={{text: 'Charles Darwin', theme: 'brand'}} name="Charles Darwin" description="[email protected]" size="2xs" /> | ||
<User avatar={{text: 'Charles Darwin', theme: 'brand'}} name="Charles Darwin" description="[email protected]" size="xs" /> | ||
<User avatar={{text: 'Charles Darwin', theme: 'brand'}} name="Charles Darwin" description="[email protected]" size="s" /> | ||
<User avatar={{text: 'Charles Darwin', theme: 'brand'}} name="Charles Darwin" description="[email protected]" size="m" /> | ||
<User avatar={{text: 'Charles Darwin', theme: 'brand'}} name="Charles Darwin" description="[email protected]" size="l" /> | ||
<User avatar={{text: 'Charles Darwin', theme: 'brand'}} name="Charles Darwin" description="[email protected]" size="xl" /> | ||
`} | ||
> | ||
<UIKit.User avatar={{text: 'Charles Darwin', theme: 'brand'}} name="Charles Darwin" description="[email protected]" size="2xs" /> | ||
<UIKit.User avatar={{text: 'Charles Darwin', theme: 'brand'}} name="Charles Darwin" description="[email protected]" size="xs" /> | ||
<UIKit.User avatar={{text: 'Charles Darwin', theme: 'brand'}} name="Charles Darwin" description="[email protected]" size="s" /> | ||
<UIKit.User avatar={{text: 'Charles Darwin', theme: 'brand'}} name="Charles Darwin" description="[email protected]" size="m" /> | ||
|
@@ -59,9 +61,18 @@ LANDING_BLOCK--> | |
| avatar | User avatar | [AvatarProps](../Avatar/README.md#properties) `React.ReactElement` | | | ||
| name | User name | `React.ReactNode` | | | ||
| description | User description | `React.ReactNode` | | | ||
| size | User block size | `'xs'` `'s'` `'m'` `'l'` `'xl'` | `m` | | ||
| size | User block size | `'2xs'` `'xs'` `'s'` `'m'` `'l'` `'xl'` | `m` | | ||
| aria-label | `aria-label` for user block | `string` | | | ||
| aria-labelledby | `aria-labelledby` for user block | `string` | | | ||
| className | Custom CSS class for root element | `string` | | | ||
| style | HTML style attribute | `React.CSSProperties` | | | ||
| qa | HTML `data-qa` attribute, used in tests | `string` | | | ||
|
||
## CSS API | ||
|
||
| Name | Description | | ||
| :--------------------------- | :--------------------------------------------------------- | | ||
| `--g-user-font-size` | Name and description font size for `size='s'` and larger | | ||
| `--g-user-line-height` | Name and description line height for `size='s'` and larger | | ||
| `--g-user-small-font-size` | Name font size for `size='xs'` and smaller | | ||
| `--g-user-small-line-height` | Name line height for `size='xs'` and smaller | | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,4 @@ | ||||||
import type {UserSize} from './types'; | ||||||
|
||||||
export const NO_DESCRIPTION_SIZES: UserSize[] = ['xs', '2xs']; | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
export const DEFAULT_USER_SIZE: UserSize = 'm'; | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CSS API is designed to ignore all props, so only 2 vars are relevant:
--g-user-font-size
,--g-user-line-height
. There should not be CSS API for props variants