chore(TextArea): rows logic #1714
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview is ready. |
|
Visual Tests Report is ready. |
|
may be it is extra now. I did not check |
korvin89
requested changes
Jul 30, 2024
|
|
||
| control.style.height = 'auto'; | ||
| let currentRowsNumber = (innerValue?.match(/\n/g) || []).length + 1; |
There was a problem hiding this comment.
It does not work in case of long strings without \n
There was a problem hiding this comment.
you are right, better calculate rows number depend on height
GermanVor
force-pushed
the
text-area-heigh
branch
from
690c4b5 to
c7e5ee4
Compare
GermanVor
force-pushed
the
text-area-heigh
branch
from
c7e5ee4 to
f887139
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It will be very useful to have y scrollbar depending not only on
rowsormaxRowsvalues, but onheightof theTextArea.now it is possible to pass
heightvalue viaTextAreaProps.classNameto see y-scrollbar